nsqadmin tests: each nsqlookupd needs its own options struct

to avoid data races setting opts.logLevel
nsqio · May 26, 2017 · 259547b · 259547b
1 parent 4203909
commit 259547b
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/nsqadmin/http_test.go b/nsqadmin/http_test.go
@@ -529,9 +529,12 @@ func TestHTTPconfig(t *testing.T) {
 
 	lopts := nsqlookupd.NewOptions()
 	lopts.Logger = test.NewTestLogger(t)
-	_, _, lookupd1 := mustStartNSQLookupd(lopts)
+
+	lopts1 := *lopts
+	_, _, lookupd1 := mustStartNSQLookupd(&lopts1)
 	defer lookupd1.Exit()
-	_, _, lookupd2 := mustStartNSQLookupd(lopts)
+	lopts2 := *lopts
+	_, _, lookupd2 := mustStartNSQLookupd(&lopts2)
 	defer lookupd2.Exit()
 
 	url := fmt.Sprintf("http://%s/config/nsqlookupd_http_addresses", nsqadmin1.RealHTTPAddr())