Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsqd: persist on disk when in-flight (optionally?) #376

Closed
tj opened this issue Jun 17, 2014 · 2 comments
Closed

nsqd: persist on disk when in-flight (optionally?) #376

tj opened this issue Jun 17, 2014 · 2 comments

Comments

@tj
Copy link
Contributor

tj commented Jun 17, 2014

totally understand that it's not a 1.0 thing but for us it's a limiting factor right now. we have to basically have excess machines just for the memory capacity, not a huge huge deal but it would be nice if they could remain on disk (at least the payload)

@jehiah
Copy link
Member

jehiah commented Jun 18, 2014

There are two in-memory priority queues where messages are kept. One handles when messages are in-flight to consumers so we can time them out appropriately, and the other is when they are requeued and are deferred until a certain time.

#34 covers the desire for a disk backed priority queue implementation so we are not memory bound by messages in those states, so i think it covers this ask.

@jehiah jehiah closed this as completed Jun 18, 2014
@mreiferson
Copy link
Member

yea, this is covered by #34, my current opinion is that I'd like to see an implementation that simply journals all messages to disk by default. The priority queues would just contain metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants