Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsqd: expose memory stats under /stats #846

Closed
ruimarinho opened this issue Jan 6, 2017 · 2 comments
Closed

nsqd: expose memory stats under /stats #846

ruimarinho opened this issue Jan 6, 2017 · 2 comments
Labels
feature help wanted request

Comments

@ruimarinho
Copy link

Currently the /stats endpoint exposes most stats that the statsd integration provides. However, it looks like memory stats are not exposed.

Enabling --statsd-mem-stats has no effect on the number of stats exposed.

Would you be open to expose these?
@mreiferson mreiferson changed the title Exposing memory stats under /stats nsqd: expose memory stats under /stats Jan 6, 2017
@mreiferson
Copy link
Member

Sure, that seems fine to me.

sparklxb added a commit to sparklxb/nsq that referenced this issue Mar 31, 2017
@sparklxb
resolve nsqio#846: nsqd: expose memory stats under /stats
670c149
sparklxb added a commit to sparklxb/nsq that referenced this issue Mar 31, 2017
@sparklxb
resolve nsqio#846: nsqd: expose memory stats under /stats
5a88882
@mreiferson mreiferson mentioned this issue Mar 31, 2017
Merged
@mreiferson
Copy link
Member

done in #874

sparklxb added a commit to sparklxb/nsq that referenced this issue Mar 31, 2017
@sparklxb
resolve nsqio#846: nsqd: expose memory stats under /stats
eeabd64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature help wanted request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mreiferson @ruimarinho