nsqadmin: Disambiguating Table Headings in Channels #184
Conversation
| @@ -143,6 +155,9 @@ | |||
| {{else}} | |||
| <table class="table table-bordered table-condensed"> | |||
| <tr> | |||
| < | |||
There was a problem hiding this comment.
I initially thought that line was a stray too but it doesn't appear to be. It looks like some Git weirdness.
There was a problem hiding this comment.
I dont know what you're talking about, see screenshot:
There was a problem hiding this comment.
actually, looks like that whole <tr> in the screenshot isn't needed
|
I ran it locally and it looks good, I think it will be helpful for clarity. cc @jehiah for naming |
| <thead> | ||
| <tr> | ||
| <th> </th> | ||
| <th colspan=4 style='text-align:center;'>Message Gauges</th> |
There was a problem hiding this comment.
For clarity, let's rename this Message Queue, and remove Message Queue from the <h4> heading above this table. All four numbers here represent actual messages outstanding so that title makes more sense scoped to these columns.
html style comments; can you quote the colspan attribute, and instead of using an inline style tag here set class="text-center". That class won't do anything yet, but i'll separately upgrade to the current bootstrap version to pick that up.
|
For some reason I had to |
|
now one more git magic trick... can you squash these down? |
|
we don't just push random commits haphazardly to master like @devdazed 😄 👊 🔥 🚒 🎆 |
|
Do you guys wonder why there aren't more contributors? |
nsqadmin: Disambiguating Table Headings in Channels
Revert fix
Added headers on top of the table headers to make it clear that the first 4 columns are message guages and the last 4 (or 5) columns are for stats. Let the naming argument commence.