nsq_tail: safety #190
Merged
nsq_tail: safety #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| log.Fatalf("--topic is required") | ||
| } | ||
|
|
||
| if !strings.HasSuffix(*channel, "#ephemeral") { |
There was a problem hiding this comment.
I can think of some use cases where you wouldn't want this restriction. Without it you could use nsq_tail to feed normal pipe chains for batch processing where you do want backlog between short runs.
There was a problem hiding this comment.
I just don't like how you can inadvertently consume messages from a live channel when all you want to do is debug.
There was a problem hiding this comment.
Yeah I think the default should continue to be "#ephemeral". I just don't wan't to limit this to only ephemeral channels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nsq_tailshould generate a random channel name and if--channelis specified it should require it to be#ephemeralcc @jehiah