nsqd: snappy/deflate compression #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is rebased on #227, RFR |
| @@ -21,8 +21,9 @@ popd >/dev/null | |||
| pushd nsqd >/dev/null | |||
| go build | |||
| rm -f *.dat | |||
| echo "starting nsqd --data-path=/tmp --lookupd-tcp-address=127.0.0.1:4160 --tls-cert=./test/cert.pem --tls-key=./test/key.pem" | |||
| ./nsqd --data-path=/tmp --lookupd-tcp-address=127.0.0.1:4160 --tls-cert=./test/cert.pem --tls-key=./test/key.pem >/dev/null 2>&1 & | |||
| cmd="./nsqd --data-path=/tmp --lookupd-tcp-address=127.0.0.1:4160 --tls-cert=./test/cert.pem --tls-key=./test/key.pem --deflate --snappy" | |||
There was a problem hiding this comment.
deflate and snappy are on by default; should we really add those flags here?
|
added large block chunk test (and fixed an issue in mreiferson/go-snappystream@93ed07e) |
* add --deflate and --max-deflate-level flag * add feature negotiation for nsqd clients
* drop defer in fast path
|
squashed @jehiah |
jehiah
added a commit
that referenced
this pull request
Sep 10, 2013
nsqd: snappy/deflate compression
This was referenced Sep 14, 2013
windzhu0514
pushed a commit
to windzhu0514/nsq
that referenced
this pull request
May 15, 2020
Update golang version in Travis (to 1.10)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as originated in #226 and #227 this adds stream level snappy and deflate feature negotiation for clients of
nsqd.we moved this out to evaluate this separately from adding TLS.
cc @jayridge @jehiah