nsqd: memory leaks #237
Merged
nsqd: memory leaks #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a channel is deleted that has clients and is actively delivering messages it is possible that messagePump() will block on its go channel write to clientMsgChan due to race between that write and the exiting of all clients subscribed to that channel. if that happens, the messagePump for the deleted channel never exits and a reference is retained preventing the channel from being GCd.
when the channels for a topic *shrinks* we weren't correctly discarding the pointer to the deleted channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two (potential) memory leaks.
see commit comments
ready @jehiah