nsqd: dont retain client pointer for inflight msgs #242
+72
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,6 +27,7 @@ type NSQd struct { | |||
| sync.RWMutex | |||
| options *nsqdOptions | |||
| workerId int64 | |||
| clientID int64 | |||
There was a problem hiding this comment.
perhaps this should be clientIDSequence or clientIDCounter or something along those lines?
|
LGTM. rebase please. |
|
comments addressed @jehiah |
more cleanup relating to what pointers might be retained preventing proper GC. this changes the in-flight messages struct so that it uses an int64 ID rather than a pointer to ensure that only the original receiver of a message can respond to it. this required changes to the channel to store clients as a map[int64]Consumer in order to lookup the proper client by ID.
jehiah
added a commit
that referenced
this pull request
Aug 5, 2013
nsqd: dont retain client pointer for inflight msgs
mreiferson
added a commit
to mreiferson/nsq
that referenced
this pull request
Aug 11, 2013
mreiferson
added a commit
to mreiferson/nsq
that referenced
this pull request
Aug 11, 2013
mreiferson
added a commit
to mreiferson/nsq
that referenced
this pull request
Aug 11, 2013
mreiferson
added a commit
to mreiferson/nsq
that referenced
this pull request
Aug 11, 2013
mreiferson
added a commit
to mreiferson/nsq
that referenced
this pull request
Aug 11, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit comments cc @jehiah