nsqd: adding user agent string to client #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My initial thought was to put it in the |
|
I've added it to the nsqadmin channels section. What should the default user agent be if one isn't passed. In other words, what should the NSQd client struct set as the default UserAgent to maintain backwards compatibility with clients that don't pass one? |
|
it should just be an empty string, and |
| @@ -201,7 +201,7 @@ func init() { | |||
| {{range .ChannelStats.Clients}} | |||
| <tr> | |||
| <td>{{.ClientIdentifier}}</td> | |||
| <td>{{.ClientVersion}}</td> | |||
| <td>{{.ClientVersion}} ({{.ClientUserAgent}})</td> | |||
There was a problem hiding this comment.
this should also be added to node.html.go in the client table
|
green light 👍 - thanks for adding a test |
mreiferson
added a commit
that referenced
this pull request
Jan 27, 2014
nsqd: adding user agent string to client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding user_agent string for client
IDENTIFY. fixes #189. This is now exposed to nsqadmin.Where was the plan for this to go in nsqadmin? The channel screen is already pretty busy with the addition of client attributes. Even though there is a node screen for NSQd nodes, there is no client screen where you can break down what an individual client is doing. Thoughts on that? Anything else in mind?