Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Auth #527

Merged
merged 65 commits into from
Jul 30, 2024
Merged

[EPIC] Auth #527

merged 65 commits into from
Jul 30, 2024

Conversation

derekpierre
Copy link
Member

@derekpierre derekpierre commented Jun 5, 2024

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

Customizable Authentication.

Comprised of PRs:

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for taco-nft-demo canceled.

Name Link
🔨 Latest commit 8cb3e9e
🔍 Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/66a3ed1abe2b900008b08982

Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for taco-demo canceled.

Name Link
🔨 Latest commit 8cb3e9e
🔍 Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/66a3ed1a2e678a0008157845

@piotr-roslaniec
Copy link
Contributor

piotr-roslaniec commented Jul 3, 2024

I think #534 became superficial - If we proceed with deprecation and removal of EIP712 we don't have to expose the complexity of managing auth providers to taco users just yet. There would be just one auth provider for the time being, the EIP4361 auth provider, and we provide it internally by wrapping ethers.Signer. So the decrypt method would not change in this release, and so on.

Other than than that I think we can merge this epic.

Edit: There is a couple of things we need to do before release like updating demos and docs, but I'm focusing on the scope of the epic here.

@vzotova vzotova mentioned this pull request Jul 18, 2024
7 tasks
@derekpierre derekpierre mentioned this pull request Jul 19, 2024
@derekpierre derekpierre changed the title [WIP] [EPIC] Auth [EPIC] Auth Jul 26, 2024
@derekpierre derekpierre marked this pull request as ready for review July 26, 2024 17:47
@derekpierre derekpierre merged commit b976284 into main Jul 30, 2024
14 of 15 checks passed
@derekpierre derekpierre deleted the epic-auth branch July 30, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants