Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EIP712 authentication method #546

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

piotr-roslaniec
Copy link
Contributor

@piotr-roslaniec piotr-roslaniec commented Jul 9, 2024

Type of PR:

  • Feature
  • Other

Required reviews:

  • 2

What this does:

  • Removes EIP712 support from the codebase

Issues fixed/closed:

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

  • Lynx example fails because of incompatibility with v7.3.0

@piotr-roslaniec piotr-roslaniec changed the base branch from main to epic-auth July 9, 2024 15:02
Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for taco-nft-demo ready!

Name Link
🔨 Latest commit e6c4e1b
🔍 Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/668d50fb73f70800082d5d21
😎 Deploy Preview https://deploy-preview-546--taco-nft-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for taco-demo ready!

Name Link
🔨 Latest commit e6c4e1b
🔍 Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/668d50fb4f38c300083a2886
😎 Deploy Preview https://deploy-preview-546--taco-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review July 11, 2024 08:51
Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! bye bye eip712 👋

@manumonti
Copy link
Member

Lyx nodes updated to v7.4.0. So now tests are passing 🙌

@manumonti manumonti mentioned this pull request Jul 11, 2024
7 tasks
Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@piotr-roslaniec piotr-roslaniec merged commit b689493 into nucypher:epic-auth Jul 11, 2024
4 checks passed
@piotr-roslaniec piotr-roslaniec deleted the remove-eip712 branch July 11, 2024 14:38
@derekpierre derekpierre mentioned this pull request Jul 25, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants