Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Porter URIs #555

Merged
merged 10 commits into from
Aug 15, 2024
Merged

GitHub Porter URIs #555

merged 10 commits into from
Aug 15, 2024

Conversation

vzotova
Copy link
Member

@vzotova vzotova commented Jul 25, 2024

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Issues fixed/closed:
Fixes #320

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:
Based on #553

@vzotova vzotova self-assigned this Jul 25, 2024
@vzotova vzotova changed the title GitHub Porter URIs [WIP] GitHub Porter URIs Jul 25, 2024
@arjunhassard arjunhassard requested review from cygnusv and theref July 26, 2024 14:06
@vzotova vzotova changed the base branch from epic-auth to epic-uris July 26, 2024 16:33
@vzotova vzotova force-pushed the github-porter-uris branch 2 times, most recently from 5bfe9bf to 59a0df1 Compare July 26, 2024 17:08
@vzotova
Copy link
Member Author

vzotova commented Jul 26, 2024

@piotr-roslaniec @cygnusv @theref To finish that PR I'd like to ask you where JSON should be stored? It can be empty for the beginning

@vzotova vzotova force-pushed the github-porter-uris branch from 59a0df1 to 742757c Compare July 26, 2024 17:10
@piotr-roslaniec
Copy link
Contributor

IMHO https://github.com/nucypher/nucypher-porter repo is fine for this purpose

@KPrasch KPrasch mentioned this pull request Jul 30, 2024
Merged
7 tasks
@vzotova vzotova force-pushed the github-porter-uris branch 2 times, most recently from a6cf462 to 8961a5a Compare July 30, 2024 13:45
@vzotova vzotova changed the base branch from epic-uris to main July 30, 2024 13:46
@netlify Netlify
Copy link

netlify bot commented Jul 30, 2024 •
edited
Loading

✅ Deploy Preview for taco-nft-demo canceled.

Name Link
🔨 Latest commit 7027418
🔍 Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/66be5b7d7a6e1400083994ec

@netlify Netlify
Copy link

netlify bot commented Jul 30, 2024 •
edited
Loading

✅ Deploy Preview for taco-demo canceled.

Name Link
🔨 Latest commit 7027418
🔍 Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/66be5b7d9eef930008be60a3

@vzotova vzotova changed the title [WIP] GitHub Porter URIs GitHub Porter URIs Jul 30, 2024
@vzotova vzotova changed the title GitHub Porter URIs [WIP] GitHub Porter URIs Jul 30, 2024
@vzotova vzotova marked this pull request as ready for review July 30, 2024 14:12
@vzotova vzotova changed the title [WIP] GitHub Porter URIs GitHub Porter URIs Jul 30, 2024
piotr-roslaniec
piotr-roslaniec reviewed Jul 30, 2024
View reviewed changes
packages/shared/src/porter.ts Outdated
protected async tryAndCall<T, D>(
config: AxiosRequestConfig<D>,
): Promise<AxiosResponse<T>> {
let resp!: AxiosResponse<T>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the ! assertion?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to mark it's 100% assigned, vs code was showing error without it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a minor smell so I guess we let it slide. But at any rate, let statements where we assign value later should not be required to ! if the branching is done properly

@piotr-roslaniec
Copy link
Contributor

@vzotova Before we merge this, it may be helpful to run the Node.js example using these new Porter URLs

@vzotova vzotova force-pushed the github-porter-uris branch from 22ff9ac to 346190d Compare August 9, 2024 17:24
derekpierre
derekpierre reviewed Aug 13, 2024
View reviewed changes
packages/taco/src/taco.ts Outdated Show resolved Hide resolved
packages/shared/src/porter.ts Outdated Show resolved Hide resolved
@derekpierre derekpierre mentioned this pull request Aug 13, 2024
Closed
@vzotova vzotova force-pushed the github-porter-uris branch from 346190d to 565eed4 Compare August 14, 2024 19:33
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.56%. Comparing base (e8f9098) to head (7027418).
Report is 144 commits behind head on main.

Files Patch % Lines
packages/shared/src/porter.ts 81.08% 5 Missing and 2 partials ⚠️
packages/taco/src/taco.ts 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #555       +/-   ##
===========================================
+ Coverage   23.12%   79.56%   +56.43%     
===========================================
  Files          62       65        +3     
  Lines       10175     6806     -3369     
  Branches      260      299       +39     
===========================================
+ Hits         2353     5415     +3062     
+ Misses       7763     1349     -6414     
+ Partials       59       42       -17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

derekpierre
derekpierre approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@derekpierre derekpierre merged commit ae5186f into nucypher:main Aug 15, 2024
9 checks passed
@derekpierre derekpierre mentioned this pull request Aug 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotr-roslaniec piotr-roslaniec piotr-roslaniec left review comments

@derekpierre derekpierre derekpierre approved these changes

@KPrasch KPrasch KPrasch approved these changes

@cygnusv cygnusv Awaiting requested review from cygnusv

@theref theref Awaiting requested review from theref

Assignees

@vzotova vzotova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fallback chain of Porters
6 participants
@vzotova @piotr-roslaniec @codecov-commenter @KPrasch @cygnusv @derekpierre