Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up exports #575

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Clean up exports #575

merged 4 commits into from
Sep 3, 2024

Conversation

theref
Copy link
Contributor

@theref theref commented Sep 2, 2024

The exports that I wanted to add have already been added!!

Fixes https://github.com/nucypher/sprints/issues/59

@theref theref requested a review from derekpierre September 2, 2024 06:47
Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for taco-nft-demo canceled.

Name Link
🔨 Latest commit 66adc5e
🔍 Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/66d5851645d8b70008d0a91f

Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for taco-demo canceled.

Name Link
🔨 Latest commit 66adc5e
🔍 Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/66d58516bb4bbf00088e323d

@theref theref changed the title Clean up exports WIP Clean up exports Sep 2, 2024
@theref theref marked this pull request as draft September 2, 2024 06:49
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.44%. Comparing base (e8f9098) to head (66adc5e).
Report is 188 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #575       +/-   ##
===========================================
+ Coverage   23.12%   88.44%   +65.31%     
===========================================
  Files          62       59        -3     
  Lines       10175     6075     -4100     
  Branches      260      311       +51     
===========================================
+ Hits         2353     5373     +3020     
+ Misses       7763      664     -7099     
+ Partials       59       38       -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theref theref changed the title WIP Clean up exports Clean up exports Sep 2, 2024
@theref theref marked this pull request as ready for review September 2, 2024 09:54
@theref theref requested a review from vzotova September 2, 2024 10:24
Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸 - nice work!

@derekpierre derekpierre merged commit b23b4b3 into nucypher:main Sep 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants