-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
comment about rule 4: "Document within the dockerfile" #99
Comments
Indeed, although if the documentation is outside the Dockerfile (and then lost) it's not very useful. Given there are projects that just grab/save Dockerfile and not surrounding context, I think Dockerfile comments are fairly important, and external to that a bonus. So they both are important. |
@vsoch Thank you for your quick reply. If a project documents everything in mark down files, possibly the documentation of the Dockerfile should be there as well. Also if the Dockerfile is generated automatically, it makes not much sense to have documentation there. I see another risk that higher concepts are forgotten when documenting in Dockerfile instead of specification (in projects that have such). Often people document in Dockerfile (or other files) only "what happens inside", but not why it is needed, where the outputs go to and so on. Of course you can always use it wrongly, such as copying a Dockerfile without its README.md :) Of course I agree that documentation is important, but creating a rule to allow to "just grab/save Dockerfile and not surrounding context" does not sound suited to me. |
Yes, but you are missing the case where an automated tool has scraped a bunch of repos to find the Dockerfile and save them separately, without context (I've done this several times). |
comment about rule 4: "Document within the dockerfile"
Whether to documentation is inside the
Dockerfile
, aREADME.txt
or a formal document going through processes and ending up as signed PDF does not matter for reproducibility I think.What is important is, that helpful documentation exists, I think.
The text was updated successfully, but these errors were encountered: