Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net5 tfm: TargetPlatformMinVersion in packed nuspec #9439

Closed
zkat opened this issue Apr 14, 2020 · 2 comments
Closed

net5 tfm: TargetPlatformMinVersion in packed nuspec #9439

zkat opened this issue Apr 14, 2020 · 2 comments
Assignees
@zkat
Labels
Functionality:Pack Partner:DotNet Priority:2 Issues for the current backlog. Type:Feature
Milestone
Sprint 174 - 2020...

Comments

@zkat
Copy link
Contributor

zkat commented Apr 14, 2020 •
edited
Loading

Ensure Pack target passes TargetPlatformMinVersion to .nuspec generator.

        <!-- something like this: (not just a single property. might have multiple dgroups. One per group.) -->
        <xs:attribute name="targetPlatformMinVersion" type="xs:string" use="optional" />
@zkat zkat added Type:DCR Design Change Request Partner:DotNet labels Apr 14, 2020
@nkolev92 nkolev92 mentioned this issue Apr 16, 2020
Closed
@nkolev92 nkolev92 added Functionality:Pack Type:Feature Priority:2 Issues for the current backlog. and removed Type:DCR Design Change Request labels Apr 16, 2020
@zkat zkat added this to the Sprint 173 - 2020.07.24 milestone Jul 6, 2020
@zkat zkat self-assigned this Jul 6, 2020
@nkolev92
Copy link
Member

nkolev92 commented Jul 6, 2020

Reading the target frameworks in the inner build is a prerequisite for this task.

@zkat zkat removed this from the Sprint 173 - 2020.07.24 milestone Jul 6, 2020
@terrajobst terrajobst mentioned this issue Jul 13, 2020
Closed
15 tasks
@zkat zkat added this to the Sprint 174 - 2020.07.27 milestone Aug 3, 2020
@zkat
Copy link
Contributor Author

zkat commented Aug 12, 2020

As per email, this is going to be taken care of by assembly attributes and analyzers, instead. No need for action on the NuGet side.

@zkat zkat closed this as completed Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zkat zkat

Labels
Functionality:Pack Partner:DotNet Priority:2 Issues for the current backlog. Type:Feature
Projects
None yet
Milestone
Sprint 174 - 2020.07.27
Development

No branches or pull requests
3 participants
@zkat @nkolev92 @heng-liu