Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package restore should fail if a package with runtime-specific assets doesn't provide an asset #1173

Closed
jasonmalinowski opened this issue Aug 13, 2015 · 6 comments
Labels
Milestone

Comments

@jasonmalinowski
Copy link
Member

Consider a package that provides runtime assets for different platforms/architectures. If you specify a different runtime than the package provides, package restore will succeed and silently not provide any runtime-specific assets. We should make that be a failure so the user doesn't get downstream failures.

@yishaigalatzer
Copy link

I think this is a valid scenario if for example the runtime assets are expected to be in the GAC for say NET45.

Do you have a specific scenario where this failure was hit?

@yishaigalatzer
Copy link

CC @anurse @davidfowl @emgarten

@yishaigalatzer yishaigalatzer added this to the 3.3.0-Beta milestone Aug 18, 2015
@yishaigalatzer
Copy link

Please reachout to @jasonmalinowski for more info, and schedule a design discussion before fixing this.

@yishaigalatzer
Copy link

@davidfowl this needs a design, do you have any thoughts on the matter?

@yishaigalatzer yishaigalatzer modified the milestones: 3.5 Beta, 3.3.0-Beta Nov 16, 2015
@davidfowl
Copy link
Member

Hmmm tricky one. What if a package provides a portable implementation for everyone but optimized implementations for specific RIDs? We need to be able to tell the difference.

@yishaigalatzer yishaigalatzer modified the milestones: 3.5 Beta, 3.5 RC Apr 8, 2016
@nkolev92
Copy link
Member

There hasn't been any traction here in a while. No customer reports?
Closing this for now. We can open a new issue if we consider it important.

@nkolev92 nkolev92 modified the milestones: Future-1, 4.6 Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants