-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package restore should fail if a package with runtime-specific assets doesn't provide an asset #1173
Comments
I think this is a valid scenario if for example the runtime assets are expected to be in the GAC for say NET45. Do you have a specific scenario where this failure was hit? |
Please reachout to @jasonmalinowski for more info, and schedule a design discussion before fixing this. |
@davidfowl this needs a design, do you have any thoughts on the matter? |
Hmmm tricky one. What if a package provides a portable implementation for everyone but optimized implementations for specific RIDs? We need to be able to tell the difference. |
There hasn't been any traction here in a while. No customer reports? |
Consider a package that provides runtime assets for different platforms/architectures. If you specify a different runtime than the package provides, package restore will succeed and silently not provide any runtime-specific assets. We should make that be a failure so the user doesn't get downstream failures.
The text was updated successfully, but these errors were encountered: