Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start + Stop Script Using Wrong Shebang #2

Open
DiCanio opened this issue Apr 14, 2021 · 0 comments
Open

Start + Stop Script Using Wrong Shebang #2

DiCanio opened this issue Apr 14, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@DiCanio
Copy link
Member

DiCanio commented Apr 14, 2021

The script files start-develop.sh and stop-develop.sh are using the following shebang: #!/bin/sh.
However, the scripts itself are not shell independent. This is because bash-specific substitutions are used.

Thus, we should explicitly state within the shebang that these scripts have to be ran with a bash (#!/usr/bin/env bash). Otherwise this will lead to problems down the line.

@DiCanio DiCanio added the bug Something isn't working label Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant