Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed validation due to ICD Codes #114

Closed
jorieck opened this issue Nov 9, 2022 · 3 comments · Fixed by #119
Closed

Failed validation due to ICD Codes #114

jorieck opened this issue Nov 9, 2022 · 3 comments · Fixed by #119
Assignees
Labels
bug Something isn't working ready for release Issue is fixed and merged into develop, ready for next release
Milestone

Comments

@jorieck
Copy link

jorieck commented Nov 9, 2022

While performing a stand alone validation, we had multiple issues with the validation of ICD Codes. For every ICD Code we were told that the validation failed without further information or any reason.

In one resource which conforms to the profile 'Stage at diagnosis' of the GECCO dataset (Link: https://simplifier.net/forschungsnetzcovid-19/diagnosiscovid19-duplicate-2) we are using both a SNOMED CT Coding and an ICD Coding:
sct icd

According to the profile this is allowed:
profile

However, after the validation the following error message shows up:
response

After we removed the ICD Codings, the validation of the resources was successful.

Is there any explanation why the validation of ICD Codes fails?

@hhund
Copy link
Member

hhund commented Nov 14, 2022

Hi @Riejo,

thank you for reporting this issue. From what I can see so far, validation of CodeableConcept elements with multiple Coding entries is not fully supported by our validator.

To be more specific, the HAPI validator we are extending is performing the validation of Codings in two steps. The Coding is first validated against the CodeSystem and then validated against the ValueSet if a binding is specified. Since we do not download the complete ICD-10 code-systems but only the ValueSet, the offline validation against the CodeSystem can not be performed, resulting in the false positive error you are reporting.

@hhund hhund added the bug Something isn't working label Nov 14, 2022
@jorieck
Copy link
Author

jorieck commented Jan 18, 2023

Hello,

is there any update regarding this bug or when it can be fixed?
Thanks

@hhund hhund self-assigned this Oct 11, 2023
@hhund hhund added this to the 1.0.0.0 milestone Oct 11, 2023
@hhund hhund linked a pull request Oct 11, 2023 that will close this issue
@hhund hhund added the ready for release Issue is fixed and merged into develop, ready for next release label Oct 11, 2023
@hhund
Copy link
Member

hhund commented Oct 11, 2023

The implementation in #119 removes the dual code checks for CodeSystems: http://fhir.de/CodeSystem/bfarm/icd-10-gm, http://fhir.de/CodeSystem/dimdi/icd-10-gm, http://fhir.de/CodeSystem/bfarm/ops and http://fhir.de/CodeSystem/dimdi/ops, http://fhir.de/CodeSystem/ifa/pzn. Codes from these systems are only checked against there ValueSets and not against the CodeSystem. We may need to reopen this issue in the future to implement a generalized solution.

@hhund hhund mentioned this issue Oct 11, 2023
@hhund hhund closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for release Issue is fixed and merged into develop, ready for next release
Projects
None yet
2 participants