Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad Conditional Update URLs #74

Closed
hhund opened this issue Jun 23, 2022 · 0 comments · Fixed by #75 or #76
Closed

Bad Conditional Update URLs #74

hhund opened this issue Jun 23, 2022 · 0 comments · Fixed by #75 or #76
Assignees
Labels
bug Something isn't working ready for release Issue is fixed and merged into develop, ready for next release
Milestone

Comments

@hhund
Copy link
Member

hhund commented Jun 23, 2022

  1. Conditional Update URLs are not URL escaped and may need to be.
  2. The URL Generator has a bug (missing .getValueAsString()) in Line 361:

else if (resource instanceof MedicationStatement)
{
MedicationStatement ms = (MedicationStatement) resource;
String profileUrl = getProfileUrl(resource, v -> v.startsWith(NUM_CODEX_STRUCTURE_DEFINITION_PREFIX));
String updateUrl = getBaseConditionalUpdateUrl(ResourceType.MedicationStatement.name(), profileUrl,
patientIdentifier);
if (ms.hasEffectiveDateTimeType() && ms.getEffectiveDateTimeType().getValueAsString() != null)
updateUrl = updateUrl + "&effective=" + ms.getEffectiveDateTimeType();
if (ms.hasMedicationCodeableConcept() && ms.getMedicationCodeableConcept().hasCoding())
updateUrl = updateUrl + "&code="
+ getCodingUpdateUrl(ms.getMedicationCodeableConcept().getCodingFirstRep());
return updateUrl;
}

@hhund hhund added the bug Something isn't working label Jun 23, 2022
@hhund hhund added this to the v0.5.1 milestone Jun 23, 2022
@hhund hhund self-assigned this Jun 23, 2022
@hhund hhund linked a pull request Jun 25, 2022 that will close this issue
@hhund hhund added the ready for release Issue is fixed and merged into develop, ready for next release label Jun 25, 2022
@hhund hhund mentioned this issue Jun 25, 2022
@hhund hhund closed this as completed in #76 Jun 25, 2022
@hhund hhund closed this as completed in 20f56eb Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for release Issue is fixed and merged into develop, ready for next release
Projects
None yet
1 participant