Skip to content

Commit

Permalink
chore: remove unused code (#125)
Browse files Browse the repository at this point in the history
Signed-off-by: a3hadi <a3hadi@protonmail.com>
  • Loading branch information
ayildirim21 authored Jul 3, 2024
1 parent ca8b5e7 commit ac3166d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 11 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/build-push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ on:

jobs:
docker_publish:
# run it only on numaproj/numaflow-java repository
# forked repositories normally don't have the proper permission setup.
# run workflow only on numaproj/numaflow-java repository
if: ${{ github.repository }} == "numaproj/numaflow-java"
name: Build, Tag, and Push Image
runs-on: ubuntu-latest
Expand Down
3 changes: 1 addition & 2 deletions development.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,4 @@ If you add a new example, there are a few steps to follow in order for it to be

1. Add the example to the `examples/pom.xml`, within an execution element. Note that the
`id` tag you specify must be exactly the same as the quay.io repository name for the example
2. Add the `id` tag you specified in step 1 to the `executionIDs` array in `hack/update_examples.sh`
3. Add the `id` tag you specified in step 1 to the `execution_ids` matrix in `.github/workflows/build-push.yaml`
2. Add the `id` tag you specified in step 1 to the `execution_ids` matrix in `.github/workflows/build-push.yaml`
8 changes: 1 addition & 7 deletions hack/update_examples.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ function show_help () {
echo "Usage: $0 [-h|--help | -t|--tag <tag>] (-bpe|--build-push-example <execution-id>)"
echo " -h, --help Display help message and exit"
echo " -bpe, --build-push-example Build the given example id (found in examples/pom.xml), and push it to the quay.io registry"
echo " -t, --tag To be optionally used with -bpe or -bp. Specify the tag to build with. Default tag: stable"
echo " -t, --tag To be optionally used with -bpe. Specify the tag to build with. Default tag: stable"
}

if [ $# -eq 0 ]; then
Expand Down Expand Up @@ -79,12 +79,6 @@ if [ -n "$tag" ] && (( ! usingHelp )); then
echo "Using tag: $tag"
fi

executionIDs=("mapt-event-time-filter-function" "flat-map-stream" "map-flatmap" \
"even-odd" "simple-sink" "reduce-sum" "reduce-stream-sum" \
"map-forward-message" "reduce-counter" "sideinput-example" \
"udf-sideinput-example" "source-simple-source" "session-reduce-count"
)

function dockerPublish () {
echo "Docker publish for example: $1"
if ! docker tag numaflow-java-examples/"$1":"$tag" quay.io/numaio/numaflow-java/"$1":"$tag"; then
Expand Down

0 comments on commit ac3166d

Please sign in to comment.