Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing version.properties file in the sdk #120

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

nagarajatantry
Copy link
Contributor

Ensure that the version.properties (renamed to numaflow-java-sdk-version.properties) is part of the thin jar

Nagaraja Tantry added 3 commits April 24, 2024 21:21
Signed-off-by: Nagaraja Tantry <nagaraja_tantry@intuit.com>
Signed-off-by: Nagaraja Tantry <nagaraja_tantry@intuit.com>
Signed-off-by: Nagaraja Tantry <nagaraja_tantry@intuit.com>
Copy link
Contributor

@yhl25 yhl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yhl25 yhl25 merged commit 14c2052 into numaproj:main Apr 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants