Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nupic.framworks.opf.opf_utils.PredictionElement is never used #3603

Closed
rhyolight opened this issue May 10, 2017 · 2 comments · Fixed by #3604
Closed

nupic.framworks.opf.opf_utils.PredictionElement is never used #3603

rhyolight opened this issue May 10, 2017 · 2 comments · Fixed by #3604
Assignees

Comments

@rhyolight
Copy link
Member

As described here:

# PredictionElement- represents a predicted record and its asssociated
#                     bit-string encoding for a network's sensor region and/or
#                     the classification of that input as produced by
#                     a classifier.
#
# predictionRow:  A sequence of field values where each element is the predicted
#                 value in the format specified by getDecodedFieldMetaInfo().
#                 This is the output of topDownCompute() for each encoder
#
# predictionEncodings: A sequence of numpy arrays, where each element is the
#                      binary representation of the corresponding predicted field
#                      in "predictionRow".
#
# classification: The classification category of this input.
#

PredictionElement = namedtuple("PredictionElement",
                                ("predictionRow",
                                 "predictionEncodings",
                                 "classification"))

This named tuple is seemingly never used in our codebase. The only place I found even a vague reference was in tests/integration/nupic/opf/expgenerator_test.py, but the test_PredictionElement test does not use the named tuple, nor does any other code.

@rhyolight
Copy link
Member Author

Docs for PredictionElement also reference obsolete function getDecodedFieldMetaInfo.

@scottpurdy
Copy link
Contributor

Probably fine to just remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants