From 2ebda9cd00bcbf50d8228d13f3b83721a1835dfc Mon Sep 17 00:00:00 2001 From: Matthew Taylor Date: Thu, 11 May 2017 14:10:33 -0700 Subject: [PATCH] Deleted nupic.support.features* (unused) --- src/nupic/support/feature_groups.py | 131 -------------------------- src/nupic/support/features.py | 140 ---------------------------- src/nupic/support/features_list.py | 75 --------------- 3 files changed, 346 deletions(-) delete mode 100644 src/nupic/support/feature_groups.py delete mode 100644 src/nupic/support/features.py delete mode 100644 src/nupic/support/features_list.py diff --git a/src/nupic/support/feature_groups.py b/src/nupic/support/feature_groups.py deleted file mode 100644 index 7d5414b81c..0000000000 --- a/src/nupic/support/feature_groups.py +++ /dev/null @@ -1,131 +0,0 @@ -# ---------------------------------------------------------------------- -# Numenta Platform for Intelligent Computing (NuPIC) -# Copyright (C) 2013, Numenta, Inc. Unless you have an agreement -# with Numenta, Inc., for a separate license for this software code, the -# following terms and conditions apply: -# -# This program is free software: you can redistribute it and/or modify -# it under the terms of the GNU Affero Public License version 3 as -# published by the Free Software Foundation. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. -# See the GNU Affero Public License for more details. -# -# You should have received a copy of the GNU Affero Public License -# along with this program. If not, see http://www.gnu.org/licenses. -# -# http://numenta.org/licenses/ -# ---------------------------------------------------------------------- - -''' -This file contains all the features that are in production or under development. -Features must be listed and described separately in features.py - -Generally new features should be added to the DEVELOPMENT group and then migrated -to the BASE_FEATURES group when we're ready to release - -Note: This could be structured with classes and inheretence. A very simple -module will probably be good enough to start with. -''' - -from nupic.support.features_list import FEATURES_LIST - -GROUPS = {} -############################################################################### -# BASE FEATURES -''' -INHERITS FROM / ADDS -''' -BASE = [ - 'base_feature', - 'second_feature', - 'third_feature' -] -''' -REMOVES -''' -# None - -GROUPS['BASE'] = BASE - -############################################################################### -# UNDER DEVELOPMENT -''' -INHERITS FROM / ADDS -''' -DEVELOPMENT = BASE + [ - 'increased_awesomeness' -] - -''' -REMOVES -''' -[DEVELOPMENT.remove(feature) for feature in [ - 'second_feature', - ] -] - -GROUPS['DEVELOPMENT'] = DEVELOPMENT - -############################################################################### -# RELEASED TO ALPHA USERS -''' -INHERITS FROM / ADDS -''' -ALPHA = BASE + [ - 'super_secret_feature' -] - -''' -REMOVES -''' -[ALPHA.remove(feature) for feature in [ - 'second_feature', - ] -] - -GROUPS['ALPHA'] = ALPHA - -############################################################################### -# A/B Test GROUP A -''' -INHERITS FROM / ADDS -''' -ALPHA_A = ALPHA #No additions - -''' -REMOVES -''' -[ALPHA_A.remove(feature) for feature in [ - 'super_secret_feature', - ] -] - -GROUPS['ALPHA_A'] = ALPHA_A - -############################################################################### -# A/B Test GROUP B -''' -INHERITS FROM / ADDS -''' -ALPHA_B = ALPHA #No Additions - -''' -REMOVES -''' -None - -GROUPS['ALPHA_B'] = ALPHA_B - -''' -All features in a given group must appear in the features.py file -''' -validFeatureNames = [f['name'] for f in FEATURES_LIST] -for groupName, features in GROUPS.iteritems(): - for feature in features: - if feature not in validFeatureNames: - raise Exception('The feature %s is not a recognized feature name. Please ' - 'check your spelling and/or add it to ' - 'nupic/support/features_list.py' % feature) diff --git a/src/nupic/support/features.py b/src/nupic/support/features.py deleted file mode 100644 index a7af2cd2e1..0000000000 --- a/src/nupic/support/features.py +++ /dev/null @@ -1,140 +0,0 @@ -# ---------------------------------------------------------------------- -# Numenta Platform for Intelligent Computing (NuPIC) -# Copyright (C) 2013, Numenta, Inc. Unless you have an agreement -# with Numenta, Inc., for a separate license for this software code, the -# following terms and conditions apply: -# -# This program is free software: you can redistribute it and/or modify -# it under the terms of the GNU Affero Public License version 3 as -# published by the Free Software Foundation. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. -# See the GNU Affero Public License for more details. -# -# You should have received a copy of the GNU Affero Public License -# along with this program. If not, see http://www.gnu.org/licenses. -# -# http://numenta.org/licenses/ -# ---------------------------------------------------------------------- - - -''' -This module implements the Feature Flags system. - -Summary: - - Based on the environment your program is run in you may want various features - to be displayed and others not. - - Based on the type of user who is using Nupic you may want them to see various - features and not others. - - These two things can be accomplished using Feature Flags. - - Feature Flags wrap sections of code in IF/THEN blocks to isolate functionality - from running code. - - This allows you to inline new features without branching files into file.py and - file2.py. - - This also allows you to release un-tested, underdevelopment, or experimental - features directly to production with confidence that those code paths won't - get run until such time as they are 'released' to a group of users for testing - or to all users for a launch. - - DEV NOTE: To set personal Feature Flag over-rides copy conf/devconf-example.py - to devconf.py and edit as desired. - -''' -import os -import sys - -from nupic.support.features_list import FEATURES_LIST -from nupic.support.feature_groups import GROUPS - - -class Features(object): - ''' - This class can be used to retrieve available and calculated features for - a given combination of running environment and user - - The class is for documentation purposes as all the methods are statically - accessible. - - Modeled after Ron's excellent Configuration class - ''' - - - @staticmethod - def hasFeature(feature, group = False, addList = False, removeList = False): - ''' - This is the primary method of the class that will return True or False - based on the current environment and user. - - This is the 'Flag' part of Feature Flags. - ''' - - return (feature in Features.getFeatures(group, addList, removeList)) - - @staticmethod - def getFeatures(group = False, addList = False, removeList = False): - ''' - Returns a list of all the active features for the current env/user - - groups: This is a list of groups the current user belongs to - addList: A list of one-off features to add - removeList: A list of one-off features to remove - ''' - - # Calculate groups - if group: - featureList = Features._getFeaturesForGroup(group) - else: - featureList = Features._getFeaturesForGroup('BASE') - - # Calculate user one-offs - if addList: - featureList.extend(addList) - if removeList: - for item in removeList: - if item in featureList: - featureList.remove(item) - - # Caclulate developer configuration - if 'TRUNK' in os.environ: - confDir = os.path.join(os.environ['TRUNK'], 'config') - confFilepath = os.path.join(confDir, 'developer.py') - if os.path.exists(confFilepath): - sys.path.append(confDir) - import developer - featureList.extend(developer.FEATURES['ADD']) - for item in developer.FEATURES['REMOVE']: - if item in featureList: - featureList.remove(item) - - return featureList - - @staticmethod - def _getFeaturesForGroup(group): - ''' - Using feature_groups.py calculate the set of features available to the given - group - ''' - return GROUPS[group] - - @staticmethod - def getAllFeatures(): - ''' - Returns a list of all known features (essentially the contents of feature_list.py) - ''' - for feature in FEATURES_LIST: - print feature['name'] + '\t\t' + feature['description'] - - @staticmethod - def getAllGroups(): - ''' - Returns a list of all known feature groups - ''' - return [group for group, features in GROUPS.iteritems()] diff --git a/src/nupic/support/features_list.py b/src/nupic/support/features_list.py deleted file mode 100644 index d0cb62e4db..0000000000 --- a/src/nupic/support/features_list.py +++ /dev/null @@ -1,75 +0,0 @@ -# ---------------------------------------------------------------------- -# Numenta Platform for Intelligent Computing (NuPIC) -# Copyright (C) 2013, Numenta, Inc. Unless you have an agreement -# with Numenta, Inc., for a separate license for this software code, the -# following terms and conditions apply: -# -# This program is free software: you can redistribute it and/or modify -# it under the terms of the GNU Affero Public License version 3 as -# published by the Free Software Foundation. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. -# See the GNU Affero Public License for more details. -# -# You should have received a copy of the GNU Affero Public License -# along with this program. If not, see http://www.gnu.org/licenses. -# -# http://numenta.org/licenses/ -# ---------------------------------------------------------------------- - - -''' -A list of all features that are in production or under development. - -Required Metadata: - name The name of the feature - description A one or two line summary of the feature - date A date string in format YYYYMMDD - author Who came up with this crazy scheme? - -''' - - - -FEATURES_LIST = [ - {'name': 'base_feature', - 'description': 'This feature must exist for all environments for Nupic to run', - 'dateAdded': '20110916', - 'author': 'idanforth'}, - - {'name': 'second_feature', - 'description': 'This is a secondary feature to use as an example', - 'dateAdded': '20110916', - 'author': 'idanforth'}, - - {'name': 'third_feature', - 'description': 'This is another feature that would be cool to have', - 'dateAdded': '20110916', - 'author': 'idanforth'}, - - {'name': 'increased_awesomeness', - 'description': 'Example feature added in default devconf-example.py', - 'dateAdded': '20110916', - 'author': 'idanforth'}, - - {'name': 'bad_feature', - 'description': 'Example feature removed in default devconf-example.py', - 'dateAdded': '20110916', - 'author': 'idanforth'}, - - {'name': 'project_delete_button', - 'description': 'A new button to delete a project from the "Projects" view', - 'dateAdded': '20110919', - 'author': 'idanforth'}, -] - - - -required_fields = ['name', 'description', 'dateAdded', 'author'] -for feature in FEATURES_LIST: - for field in required_fields: - val = feature.get(field) - if not val: - raise Exception('Field "%s" is required. Feature: %s' % (field, str(feature)))