-
Notifications
You must be signed in to change notification settings - Fork 278
Conversation
Windows is causing troubles:
Here https://ci.appveyor.com/project/numenta-ci/nupic-core/build/0.3.0.2226/job/22yglo6elbtw1u80#L1358 And the solution can be found
EDIT: |
src/CMakeLists.txt
Outdated
# https://github.com/numenta/nupic.core/pull/1321#issuecomment-356665619 | ||
-python | ||
-I${SWIG_PATH}/Lib | ||
-I${SWIG_PATH}/Lib/python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit moves us from
#1321 (comment)
to
https://ci.appveyor.com/project/numenta-ci/nupic-core/build/0.3.0.2227/job/hcx4ji7p9s5pbg0i#L1357
@rhyolight do you know someone on Windows who can look into the swig paths? Where the new swig binary is located and what paths it expects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@breznak I added windows support to your branch with this PR breznak#3
Here is the windows build log:
CC: @rhyolight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing windows side of the new swig ... Help wanted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see breznak#3
Fix Windows build
Thank you @lscheinkman for the Win fix!
|
Fixes #1293
Replaces #1318
TODO: