Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource hint elements have unnecessary </link> closing tag #16

Closed
skisor opened this issue Apr 9, 2017 · 5 comments
Closed

Resource hint elements have unnecessary </link> closing tag #16

skisor opened this issue Apr 9, 2017 · 5 comments

Comments

@skisor
Copy link

skisor commented Apr 9, 2017

Try

new ScriptExtHtmlWebpackPlugin({
  preload: {
    test: ...,
    chunks: 'async'
  }
}),

Expected

<link rel="preload" href="..." as="script">

Actual

<link rel="preload" href="..." as="script"></link>

"script-ext-html-webpack-plugin" version: 1.7.1
"html-webpack-plugin": 2.24.1
"webpack": 2.2.1
"node": 6.2.0

W3C says:

In HTML the tag has no end tag.

https://www.w3schools.com/tags/tag_link.asp

@numical
Copy link
Owner

numical commented May 10, 2017

Fixed on v1.7.2

@numical numical closed this as completed May 10, 2017
@lacoe
Copy link

lacoe commented Jan 18, 2018

I still receive generated link ending with /> If I change the selfClosingTag to true in resource-hints.js file the generated link is OK.

@numical numical reopened this Jan 21, 2018
@numical
Copy link
Owner

numical commented Jan 21, 2018

HI @lacoe - selfClosingTag has been true in resource-hints.js since 1.7.2. What version are you using?

@xiao-hu
Copy link

xiao-hu commented Mar 26, 2018

I am also seeing the same issue. What even worse, the closing slash causes html-webpack-pug-plugin fail to work. For me, the generated links are OK if I changeselfClosingTag to false. I am using version 2.0.1.

@numical
Copy link
Owner

numical commented Oct 26, 2020

Hello - I'm sorry to say that this plugin is no longer being maintained. I have tried to close all issues ahead of doing this but instead have found that the issue list just keeps growing. I simply do not have the time to keep up. Sorry.
Please keep an eye on the README where I will record anyone who forks this repo with the intention to supporting it in the future.

@numical numical closed this as completed Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants