Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture the type of virtualised environment #6

Closed
1 task done
brianmcgee opened this issue Jun 12, 2024 · 3 comments · Fixed by #21 or #75
Closed
1 task done

Capture the type of virtualised environment #6

brianmcgee opened this issue Jun 12, 2024 · 3 comments · Fixed by #21 or #75
Assignees
@brianmcgee
Labels
enhancement New feature or request
Milestone
Replicate nixos-g...

Comments

@brianmcgee
Copy link
Member

brianmcgee commented Jun 12, 2024 •
edited

Mostly implemented.

For reference https://github.com/NixOS/nixpkgs/blob/dac9cdf8c930c0af98a63cbfe8005546ba0125fb/nixos/modules/installer/tools/nixos-generate-config.pl#L274-L301

TODO

  • [ ] detect_vm_zvm
  • detect_vm_xen
  • [ ] container detection
@brianmcgee brianmcgee added the enhancement New feature or request label Jun 12, 2024
@brianmcgee brianmcgee mentioned this issue Jul 22, 2024
Merged
2 tasks
@brianmcgee
Copy link
Member Author

brianmcgee commented Aug 1, 2024 •
edited

virt.c has only been partially ported.

@brianmcgee brianmcgee reopened this Aug 1, 2024
@brianmcgee brianmcgee changed the title Handle virtualised environments Capture the type of virtualised environment Aug 1, 2024
@brianmcgee brianmcgee mentioned this issue Aug 1, 2024
Closed
@brianmcgee
Copy link
Member Author

Container detection is only needed for NixOS/nixpkgs@b162338.

Why would you run the installer inside a container where the OS isn't already NixOS? I don't think we need to support it.

ZVM support is IBM mainframe stuff (we think), which we don't support in NixOS anyway. We don't need to support it.

XEN is necessary.

@brianmcgee brianmcgee self-assigned this Aug 1, 2024
@brianmcgee brianmcgee mentioned this issue Aug 13, 2024
Merged
@brianmcgee
Copy link
Member Author

@Mic92 mentioned he might know someone who can test this out for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianmcgee brianmcgee

Labels
enhancement New feature or request
Projects
NixOS Facter
Status: Done
Milestone
Replicate nixos-generate-config.pl fu...
Development

Successfully merging a pull request may close this issue.

feat/virtualization numtide/nixos-facter
feat: detect Xen domU or dom0 numtide/nixos-facter
1 participant
@brianmcgee