Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support executing a MSYS shell #1

Closed
eine opened this issue Oct 6, 2019 · 7 comments · Fixed by #6
Closed

Support executing a MSYS shell #1

eine opened this issue Oct 6, 2019 · 7 comments · Fixed by #6

Comments

@eine
Copy link
Contributor

eine commented Oct 6, 2019

The shell in msys2do.cmd is set to MINGW64:

set MSYSTEM=MINGW64

Please, allow to provide this as an envvar or cli arg, so it is possible to start MSYS shells too (required to build PKGBUILD files, i.e., MSYS2 packages).

@Ecco
Copy link
Contributor

Ecco commented Oct 6, 2019

Yeah, that's a great idea. We personally won't have any use for this so I don't think I'll have the time to write the corresponding code, but I'd happily merge a PR for this 😄

@eine
Copy link
Contributor Author

eine commented Oct 6, 2019

What approach do you suggest?

  • Remove line 3 from msys2do.cmd and tell users to set MSYSTEM=whatever.
  • Or, triplicate msys2do.cmd.
  • Or, take the first cli arg passed to msys2do.cmd and use it to set the envvar.

@Ecco
Copy link
Contributor

Ecco commented Oct 6, 2019

That's a good question. I think I'd go for an option in the yml file:

- uses: numworks/setup-msys2@v1
  with:
    msystem: whatever

This option would simply be forwarded to the MSYSTEM environment variable (or default to MINGW64 if not set). Then msys2do would just not modify the MSYSTEM variable so this could be overriden per-command.

@eine
Copy link
Contributor Author

eine commented Oct 6, 2019

I'm trying to test my changes before opening a PR, but I cannot use the action, not even numworks/setup-msys2@v1. See https://github.com/1138-4EB/setup-msys2/runs/249792370#step:2:3

@Ecco, does it work for you?

@Ecco
Copy link
Contributor

Ecco commented Oct 6, 2019

Dude… you're trying to run msys2 on Ubuntu 😁

That being said, it's definitely something we could check.

@eine
Copy link
Contributor Author

eine commented Oct 6, 2019

Stupid of me! Thanks a lot! I even forked this other project of yours to be sure https://github.com/1138-4EB/epsilon/runs/249816649 I seems it is getting late and my brain is starting to complain 😄 My apologies for the noise...

@Ecco
Copy link
Contributor

Ecco commented Oct 6, 2019

That's allright 😄 Someone else might be bitten by this so I created #2 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants