Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateDraftRelease is being run incorrectly #27

Closed
CharliePoole opened this issue Sep 19, 2024 · 1 comment · Fixed by #32
Closed

CreateDraftRelease is being run incorrectly #27

CharliePoole opened this issue Sep 19, 2024 · 1 comment · Fixed by #32
Assignees
@CharliePoole
Labels
Bug Something isn't working
Milestone
1.2.0

Comments

@CharliePoole
Copy link
Member

When building the tagged main for a release, the script is running CreateDraftRelease, which should be skipped in this situation. Since their is no longer a draft release at this point, that task fails and CreateProductionRelease is never executed.
@CharliePoole CharliePoole added the Bug Something isn't working label Sep 19, 2024
@CharliePoole CharliePoole self-assigned this Sep 19, 2024
@CharliePoole CharliePoole mentioned this issue Oct 8, 2024
Merged
@CharliePoole CharliePoole added this to the 1.2.0 milestone Oct 8, 2024
@CharliePoole
Copy link
Member Author

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CharliePoole CharliePoole

Labels
Bug Something isn't working
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Fix logic for when draft release is created nunit/NUnit.Cake.Recipe
1 participant
@CharliePoole