Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI on PRs and master #1386

Closed
mikkelbu opened this issue Jan 27, 2024 · 3 comments
Closed

Run CI on PRs and master #1386

mikkelbu opened this issue Jan 27, 2024 · 3 comments
Assignees
Milestone

Comments

@mikkelbu
Copy link
Member

It seems like we are only running two checks on PRs: WIP and license/cla. So this means that neither AppVeyor nor Azure pipelines are being run as checks on PRs or master (note that AppVeyor run on on both PR and master, but not as a check).

image

@CharliePoole
Copy link
Member

@mikkelbu I turned off Azure back when I was working on it a year ago. It wasn't working well for me and I was unfamiliar with Azure - and didn't care to get familiar. :-) Working as a contributor, I think I'd just go do something else if I had azure failures right now - AppVeyor is bad enough!

I've always been an advocate of asking committers to not commit until everything is passing but I'm frankly not a fan of software-enforced rules. For one thing, it smells like distrust to me and you shouldn't give people commit authority if you don't trust them to follow sensible rules on their own. Also, most rules need to be overridden from time to time and that often requires a higher level of authority - i.e. asking @OsirisTerje to do it. Given that so few people are working on this, it seems wrong to add obstacles.

As it happens, I just had to push directly to main because of an unresolved. GitVersion bug encountered when trying to run a PR. If that check were in place, I would have been stuck, but I could see that the error had nothing to do with what I was doing and was able to merge and test locally, then push and trigger a build of main, which resolved the bug.

@CharliePoole CharliePoole added this to the 3.18.2 milestone Aug 14, 2024
@CharliePoole CharliePoole self-assigned this Aug 14, 2024
@CharliePoole
Copy link
Member

A GitHub CI workflow is now run in lieu of the AppVeyor build. It's still not a check for the reasons stated a few months back.

@CharliePoole
Copy link
Member

This issue has been resolved in version 3.18.2

The release is available on:
GitHub.
NuGet packages are also available NuGet.org and
Chocolatey Packages may be found at Chocolatey.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants