We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug When asserting a pointer-error with HaveOccurred or Succeed, ginkgolinter detect the value as non error, and triggers a linter error.
HaveOccurred
Succeed
To Reproduce
type myErr struct { code int } func (e *myErr) Error() string { ... } ... err = &myErr{code: 404} Expect(err).To(HaveOccured())
Expected behavior no linter error
Actual behavior ginkgolinter mistakely detects err as not error type.
err
Environment:
Additional context Originally found here: containernetworking/cni#1148
The text was updated successfully, but these errors were encountered:
Released version with the fix: v0.18.4
Sorry, something went wrong.
nunnatsa
Successfully merging a pull request may close this issue.
Describe the bug
When asserting a pointer-error with
HaveOccurred
orSucceed
, ginkgolinter detect the value as non error, and triggers a linter error.To Reproduce
Expected behavior
no linter error
Actual behavior
ginkgolinter mistakely detects
err
as not error type.Environment:
Additional context
Originally found here: containernetworking/cni#1148
The text was updated successfully, but these errors were encountered: