🐛 JavaScript error "Uncaught ReferenceError: oid is not defined" is thrown when not using Firebase integration

[ragibson]

Describe the bug
Pages with posts throw a ReferenceError in the console when not using a Firebase integration.

To Reproduce
Steps to reproduce the behavior:
View any Blowfish website without likes enabled and you'll see it in the console. Pulling a few arbitrarily from the Blowfish users page: https://joshblais.com/posts/, https://zen96k.github.io/enoshima-escar/posts/, https://blog.wtcx.dev/posts/, etc.

Expected behavior
No errors are thrown in the console.

Screenshots

Desktop

• OS: Linux, Windows
• Browser: Firefox, Chrome
• Version: Most recent / various

Hugo & Blowfish versions
The most recent version, though it seems to affect a wide range of them.

Additional context
At a glance, this is probably caused by 6190898.

[wtchangdm]

The problem is that

blowfish/layouts/_default/list.html

Lines 29 to 32 in 18ed67b

	<script>
	var oid = "views_{{ $path }}"
	var oid_likes = "likes_{{ $path }}"
	</script>

doesn't get rendered as expected so there is no oid and oid_likes to being with. Not sure what does this part try to do with the translations.

One way to simply suppress the error is to add some guards here:

blowfish/assets/js/page.js

Lines 1 to 5 in 18ed67b

	var liked_page = false
	var id = oid ? oid.replaceAll("/", "-") : oid
	var id_likes = oid_likes ? oid_likes.replaceAll("/", "-") : oid_likes
	if (typeof auth !== 'undefined') {

[ragibson]

I agree that the guards would work, but I've opted to just include the scripts in the relevant statement scopes to better target the root cause here. Let's see what nunocoracao says in the PR.