-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Carousel with Remote Images #736
Comments
@ChrisRisner thanks for opening this one. Sorry for the late reply. I will try to have a look but this one might require some rework of the shortcode. If you have fixed it and want to submit a PR let me know. |
yeah. I found that as is, content/snippits/blowfish/shortcodes/_index.md
content/snippits/blowfish/shortcodes/carousel.md
content/snippits/blowfish/shortcodes/carousel-branch/_index.md
content/snippits/blowfish/shortcodes/carousel-branch/branch-samedir.jpg
content/snippits/blowfish/shortcodes/carousel-leaf/index.md
content/snippits/blowfish/shortcodes/carousel-leaf/subdir/leaf-subdir.jpg
content/snippits/blowfish/shortcodes/01.jpg
content/snippits/blowfish/shortcodes/gallery/01.jpg in the above exemplar:
|
Thanks @aakashnand the other PR helped on this one |
Description:
I'm just getting started with the Hugo theme and I'd like to put a carousel on a page but reference images on a remote server by full URL. It seems to work fine with the Gallery Shortcode but I'm not getting it to work with the Carousel.
To Reproduce
Create a page with a carousel similar to the below. Note that the below uses several different methods of trying to set paths for images:
{{< carousel images="{featured.png, 'https://www.mywebsite.com/myimage.jpg', /img/logo2.png, /assets/img/myimage.jpeg, bop.jpeg}" >}}
Expected behavior
The Carousel loads with different pathing types working.
Screenshots
Hugo & Blowfish versions
Hugo: v0.111.3
Blowfish: 2.33.0
Additional context
It may be that not all paths should work here but it seems like at least fully qualified URLs to images should work or guidance in the doc could be updated to indicate what does work.
The text was updated successfully, but these errors were encountered: