Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consistent rep interval capitalization #2273

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

Erotemic
Copy link
Contributor

@Erotemic Erotemic commented Dec 7, 2024

In the English localization, the capitalization of "max rep interval" is inconsistent with other column names, which are capitalized. See screenshot:

image

This PR capitalizes the "M".

There were other capitalizations in the en.json file that looked suspect, but I didn't change any as I haven't observed them as inconsistent in the UI itself.

On a side note: It took me a sec to realize "rep" stood for reporting. Would it make sense to add a tooltip to get a description without an abbreviation?

@Erotemic
Copy link
Contributor Author

Erotemic commented Dec 7, 2024

Just saw that I should probably do things like this in poeditor.com? I suggested the change there. Not sure how that works in terms of review / bringing in the changes into the repo. This can be closed if needed.

@Koenkk
Copy link
Collaborator

Koenkk commented Dec 7, 2024

I think en should be edited here, thanks!

@Koenkk Koenkk merged commit ed5a73b into nurikk:dev Dec 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants