Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[str replace] add exemple for escaped regexes #14038

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

quadristan
Copy link
Contributor

Description

This is a follow-up of nushell/nushell.github.io#1584

The goal is to provide the user understanding of how to escape strings

User-Facing Changes

Nothing except documentation

Tests + Formatting

I don't know why but these two tests are failing on my system:

  • test_std_util path_add
  • commands::umkdir::mkdir_umask_permission

Since I hardly believe it is linked to my changes, I will let your CI check it. Meanwhile, I will check my system, highly likely that it is something something related to me recently switching shells, hacking my way through prompts environments, etc.

After Submitting

Will check how to re-generate the the documentation after the PR is merged

@fdncred fdncred merged commit 2979595 into nushell:main Oct 9, 2024
13 checks passed
@fdncred
Copy link
Collaborator

fdncred commented Oct 9, 2024

Thanks

@fdncred fdncred added the pr:commands This PR changes our commands in some way label Oct 9, 2024
@hustcer hustcer added this to the v0.99.0 milestone Oct 9, 2024
@quadristan quadristan deleted the ex-replace-escaped branch October 10, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:commands This PR changes our commands in some way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants