Don't panic when parent directory does not exist #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sholderbach
reviewed
Jun 2, 2022
Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
sholderbach
changed the title
3 tasks
sholderbach
added a commit
to nushell/nushell
that referenced
this pull request
Jun 3, 2022
Resolves an unexpected issue due to `Deref` and `ToString` interacting Details: nushell/nu-ansi-term#5 and nushell/reedline#435 (comment) Also updates reedline: Includes a fix for a panic when the directory containing the history is deleted during a running reedline session. (nushell/reedline#436)
fennewald
pushed a commit
to fennewald/nushell
that referenced
this pull request
Jun 27, 2022
Resolves an unexpected issue due to `Deref` and `ToString` interacting Details: nushell/nu-ansi-term#5 and nushell/reedline#435 (comment) Also updates reedline: Includes a fix for a panic when the directory containing the history is deleted during a running reedline session. (nushell/reedline#436)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative: nushell/nushell#5203
After investigate, I think
nuwill crash is because history file's parent is deleted, and it leads to file sync operation failed.Refer to the expected behavior in that issue:
I think that's too complicated to implement such feature, instead, we can make
nuwork as normal (because config is loaded to memory), we just need to create that missing directory.