Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For every patch handler, implement a tests verifies the handler is idempotent #479

Open
dlipovetsky opened this issue Mar 27, 2024 · 0 comments

Comments

@dlipovetsky
Copy link
Contributor

Idempotence: An External Patch Extension must only return patches if changes to the templates are required, i.e. unnecessary patches when the template is already in the desired state must be avoided.
-- https://cluster-api.sigs.k8s.io/tasks/experimental-features/runtime-sdk/implement-topology-mutation-hook#patch-extension-guidelines

This is especially important any patch that appends to an array, since a patch that is not idempotent will append redundant elements to the array when it is called two or more times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant