Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): support id as a function (asyncID) #43

Merged
merged 3 commits into from
Mar 8, 2019
Merged

feat(plugin): support id as a function (asyncID) #43

merged 3 commits into from
Mar 8, 2019

Conversation

ricardogobbosouza
Copy link
Member

The option id as function is compatible but with this commit will also receive context as parameter.

Resolve #32

@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #43   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          13     13           
  Branches        4      4           
=====================================
  Hits           13     13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a78c43...39f9e8f. Read the comment docs.

lib/plugin.js Outdated Show resolved Hide resolved
@ricardogobbosouza
Copy link
Member Author

@pi0
Any other suggestions?

@pi0 pi0 changed the title feat(plugin): support id as a function feat(plugin): support id as a function (asyncID) Mar 8, 2019
@pi0 pi0 merged commit 6b6809e into nuxt-community:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants