-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: preserve default headers with custom headers #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ed
reviewed
Dec 14, 2020
Co-authored-by: Gábor Egyed <gabor.egyed@gmail.com>
pi0
changed the title
fix: try to fix #411
fix: preserve default headers with custom headers
Dec 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
=======================================
Coverage 95.55% 95.55%
=======================================
Files 1 1
Lines 45 45
Branches 25 25
=======================================
Hits 43 43
Misses 2 2 Continue to review full report at Codecov.
|
This was referenced Mar 11, 2021
This was referenced Sep 14, 2024
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a breaking change with axios axios/axios@v0.19.2...v0.20.0 that when passing headers config when calling
axios
, it discardsdefaults.headers.common
(used for both config andsetHeader
utility.resolves #411
Update: Axios regression found by @1ed regarding defaults overriding: axios/axios#2844 <3
Test flow for #411:
/api/cookie
endpoint that simply returns value ofmycookie
header if setmycookie
"/api/cookie
inasyncData
using$axios
to check what headers are passed to API when using axios in server sideLocally trying:
yarn install
fix/411
branchyarn dev