-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
static/icon.png hash is not invalidated with target: static
#353
Comments
I was struggling with this too. I found out that leaving the
Now the icon builds again. |
@leopoldkristjansson Thanks for the tip, I'll have to try that out in the meantime. |
This works for me thanks! |
Hello, guys is there a way of the icon.source being an external image URL, please. I am working on a dynamic subdomain kind of app and need to generate different icons basing on the logo of the current subdomain app
Thank you, please. |
I think it isn't possible with this module, as it generates icons on manifest.json. The closes I could find is this article |
Hey, @ponnex Let me check out that link, please. Thank you |
The icon is cached in |
Yeah, that's right. Actually, I just added an icons array in the manifest option abject. and disabled the icons module. |
Hey @ponnex Later I figured that my problem is bigger. I am trying to build an app like "StudioYou" - the one you referred in the article above, It is called myduuka.com, It's a platform for creating online shops, whereby each user can have an independent online shop on their subdomain. So I have been trying to make a request to the server according to the current host(subdomain) so that I can get the data for that particular subdomain. But since to my knowledge, I can't access the window.location.host (subdomain) from the nuxt.config, I am stuck there currently |
Ahh i see. This is a bug with nuxt smart rebuild as we don't hash static dir (so Some workarounds:
|
target: static
Hi. Sorry for inconveniences. This issue should be resolved by v3.2.0 without need to workaround above. |
This worked for me, thank you. 💯 |
The app icon images that are generated seem to use the default/initial icon.png image for icon generation when using the default icon.png filename. I tried different configurations to get it to refresh, and I ended up having to build once using an alternate filename, and then switch the filename back to the original, then build again, in order to allow the new icon.png file to be used.
Nuxt version: 2.14.5 and 2.14.6
This occurred in both @nuxt/pwa v3.0.0-beta20 and v3.0.2
Initial run. No options added to config. I updated icon.png file in static dir folder. Result: The new icon.png image was not used to generate icon files, instead the old icon.png file was used.
Next attempt: Setting the values in the options also did not use new icon.png image, still the old icon.png image was used.
Finally got a new image to be used for generation by first changing the filename+source to a different file,
I then changed the icon config back to the default filename, added a new icon.png file to the static directory, ran build, and the new icon.png file was used correctly.
The text was updated successfully, but these errors were encountered: