Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manual import #110

Merged
merged 1 commit into from
Aug 19, 2019
Merged

feat: manual import #110

merged 1 commit into from
Aug 19, 2019

Conversation

Yihao-G
Copy link
Contributor

@Yihao-G Yihao-G commented Aug 9, 2019

Related : #109

A proposal for the implementation of manually importing feature

The configuration of this uses treeShake attribute as manually importing is closely related to tree-shaking. treeShake now accepts:

  • false (no tree-shaking),
  • true (enables tree-shaking but no manual imports), or,
  • an object with components, directives and/or transitions properties, each of the property is optional and accepts an array of strings of the element names that are being imported (enables tree-shaking and manually importing):
{
  components: [
    'VCard',
    'VRating',
    'VToolbar'
  ],
  directives: [
    'Ripple'
  ],
  transitions: [
    'VFadeTransition'
  ]
}

@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #110   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          44     43    -1     
  Branches       10     10           
=====================================
- Hits           44     43    -1
Impacted Files Coverage Δ
lib/module.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97c5944...3b05738. Read the comment docs.

@kevinmarrec kevinmarrec added the feature Pull requests that implement a feature label Aug 9, 2019
@kevinmarrec
Copy link
Member

Hey @Yihao-G, what you have done seems really nice !
After quick look, I would suggest some refactors to shorten the plugin template code, but if you don't mind I'll be able to merge that and take the lead on the refactor ;)

PS: Just letting you know, I won't be able to fully review the PR before 1 week starting now, cause I'm taking some vacations and gonna be off computer.

@Yihao-G
Copy link
Contributor Author

Yihao-G commented Aug 11, 2019

Hi @kevinmarrec
Thank you. Feel free to merge and refactor the template code. It's my first time writing lodash template code and I would like to see how you improve it.

Also have a wonderful holiday :)

@kevinmarrec kevinmarrec changed the base branch from master to feat/manual-import August 19, 2019 13:46
@kevinmarrec
Copy link
Member

@Yihao-G I'm gonna dive in soon ! I'm merging it in a new branch and creating new PR so you can track easier the refactor :)

@kevinmarrec kevinmarrec merged commit 2449eb3 into nuxt-community:feat/manual-import Aug 19, 2019
@kevinmarrec kevinmarrec mentioned this pull request Aug 19, 2019
kevinmarrec pushed a commit that referenced this pull request Aug 24, 2019
* feat: manual import - initial state (#110)

* feat: manual import

* fix: treeshake false situation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that implement a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants