-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace treeShake with globalImports #239
Conversation
treeShake has been renamed to globalImports everywhere except for plugin.js This is fixes with this pull request
Codecov Report
@@ Coverage Diff @@
## next #239 +/- ##
===================================
Coverage 100% 100%
===================================
Files 7 7
Lines 64 64
Branches 19 19
===================================
Hits 64 64 Continue to review full report at Codecov.
|
nice catch @husayt , but seems there's something to do as well around plugin registration : https://github.com/nuxt-community/vuetify-module/blob/next/src/plugin.ts#L23 , |
@kevinmarrec this is done now |
The Vuetify module will always now import Vuetify from vuetify/lib which will provide natural tree shaking with Webpack.
@kevinmarrec seems you were looking at old changes. Can you check again pls |
@husayt Still doesn't look good to me in "Files" tab 🤷, is it GH issue or ? |
Can you point to what is wrong @kevinmarrec . I actually did those changes directly in github as I didn't have a chance to edit files locally. Feel free to change what doesn't look right. |
Well the things you marked as resolved are not resolved :
|
Indeed, you are right. Something is weird with Github editor, I am sure I did those changes yesterday. Nevermind, all should be fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @husayt 😉
I will release later today :) |
treeShake has been renamed to globalImports everywhere except for plugin.js This is fixed with this pull request