feat: set permissions on binaries

danielroe · Jun 8, 2020 · 05b92d1 · 05b92d1
1 parent b9b27af
commit 05b92d1
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 3 deletions.
diff --git a/packages/cli/src/commands/build.ts b/packages/cli/src/commands/build.ts
@@ -57,9 +57,10 @@ export async function build({ packages, ...options }: BuildCommandOptions) {
     // Step 3: Link dependencies and Fix packages
     pkg.syncLinkedDependencies()
     pkg.autoFix()
-    pkg.writePackage()
+    await Promise.all([...pkg.setBinaryPermissions(), pkg.writePackage()])
   })
-  performance.mark('Stop build')
+  if (watch) return
 
+  performance.mark('Stop build')
   performance.measure('Finished build', 'Start build', 'Stop build')
 }
diff --git a/packages/core/src/package/package.ts b/packages/core/src/package/package.ts
@@ -1,5 +1,12 @@
 import { dirname, resolve } from 'path'
-import { readJSONSync, writeFile, copy, remove, existsSync } from 'fs-extra'
+import {
+  chmod,
+  copy,
+  existsSync,
+  readJSONSync,
+  remove,
+  writeFile,
+} from 'fs-extra'
 
 import consola, { Consola } from 'consola'
 import { bold, gray } from 'chalk'
@@ -389,6 +396,20 @@ export class Package {
     }
   }
 
+  get binaries() {
+    const { bin } = this.pkg
+    const files = !bin
+      ? []
+      : typeof bin === 'string'
+      ? [bin]
+      : Object.values(bin)
+    return Array.from(new Set(files.map(file => this.resolvePath(file))))
+  }
+
+  setBinaryPermissions() {
+    return this.binaries.map(file => chmod(file, 0o777))
+  }
+
   async getWorkspacePackages(packageNames?: string[]) {
     const packages: Package[] = []
 
@@ -402,6 +423,7 @@ export class Package {
     for (const dir of dirs) {
       if (existsSync(this.resolvePath(dir, 'package.json'))) {
         const pkg = new Package({
+          ...this.options,
           rootDir: this.resolvePath(dir),
         })
         if (!packageNames || packageNames.includes(pkg.pkg.name)) {