-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Version 2 #39
feat!: Version 2 #39
Conversation
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 2 -2
Lines 40 20 -20
Branches 6 3 -3
=========================================
- Hits 40 20 -20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (only downside is that we cannot support cross domain theme)
cookie
option in the V1, if you don't use it, you can upgrade easily.Force a color mode
You can force the color mode at the page level (only parent) by setting the
colorMode
property:This feature is perfect for implementing dark mode to a website incrementally by setting the non-ready pages to
colorMode: 'light'
.We recommend to hide or disable the color mode picker on the page since it won't be able to change the current page color mode, using
$colorMode.forced
value.See example: https://color-mode.nuxtjs.app/light
Local Storage only
This will also fixes #38
Using a cookie is only worth for doing server-side rendering with no cache, where actually localStorage work in every-case and won't lead to a flash on client-side anyway.
This also simplify the options and reduce the dependency with the
cookie
package.To customize the storage key, you now have to use the
storageKey
property instead ofcookie.key
.