Unexpected window in created #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error from eslint(nuxt/no-globals-in-created)
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 19 19
Branches 2 2
=========================================
Hits 19 19 Continue to review full report at Codecov.
|
This was referenced Mar 11, 2021
Closed
iamahuman
pushed a commit
to iamahuman/color-mode-module
that referenced
this pull request
Feb 9, 2022
This reverts commit 9b47c6e. Fix a regression that prevents cross-window dark mode synchronization from working, by putting the storage watcher back to the created() hook. This bug is caused by the mounted() hook never being invoked, since the $colorMode component is not actually mounted anywhere. Also note that there's nothing wrong in referencing "window" in the created() hook; this is a client plugin, and other code in the same file references "window" already.
iamahuman
pushed a commit
to iamahuman/color-mode-module
that referenced
this pull request
Feb 9, 2022
This reverts commit 9b47c6e. Put the storage watcher back to the created() hook. This fixes the regression that breaks cross-window dark mode synchronization. This bug is caused by the mounted() hook never being invoked, since the $colorMode component is not actually mounted anywhere. Also note that there's nothing wrong in referencing "window" in the created() hook; this is a client plugin, and other code in the same file references "window" already.
iamahuman
pushed a commit
to iamahuman/color-mode-module
that referenced
this pull request
Feb 9, 2022
This reverts commit 9b47c6e. Put the storage watcher back to the created() hook. This fixes the regression that breaks cross-window dark mode synchronization. This bug is caused by the mounted() hook never being invoked, since the $colorMode component is not actually mounted anywhere. Also note that there's nothing wrong in referencing "window" in the created() hook; this is a client plugin, and other code in the same file references "window" already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error from eslint(nuxt/no-globals-in-created)