Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing query hash param when loading virtual conf #2211

Closed
userquin opened this issue Jul 8, 2023 · 1 comment · Fixed by #2212
Closed

missing query hash param when loading virtual conf #2211

userquin opened this issue Jul 8, 2023 · 1 comment · Fixed by #2212

Comments

@userquin
Copy link
Collaborator

userquin commented Jul 8, 2023

Environment

npx nuxi info
Nuxi 3.6.2                                                                                                                                                                14:22:00
                                                                                                                                                                          14:22:00
RootDir: D:/work/projects/userquin/GitHub/userquin/vuetify-nuxt-module-i18n-beta13                                                                                        14:22:00
Nuxt project info:                                                                                                                                                        14:22:00

------------------------------
- Operating System: Windows_NT
- Node Version:     v18.16.0
- Nuxt Version:     3.6.2
- Nitro Version:    2.5.2
- Package Manager:  pnpm@8.6.6
- Builder:          vite
- User Config:      -
- Runtime Modules:  -
- Build Modules:    -
------------------------------

Reproduction

Fork https://github.com/userquin/vuetify-nuxt-module/ and then chekout userquin/fix-rtl-locale-support branch:
https://github.com/userquin/vuetify-nuxt-module/tree/userquin/fix-rtl-locale-support (I'm working in the PR to add RTL support to Vuetify 3)

Run pnpm install, and then you can run:

  • nr dev:prepare && nr dev: for single json file per locale
  • nr dev:prepare:multiple-json && nr dev:multiple-json: for multiple json files per locale

Describe the bug

When resolving i18n config file missing hash query param:

beta 13

imagen

beta 12

imagen

Additional context

I'm preparing a PR to fix the error, PR in a few minutes.

Patching proxy module just works:

imagen

imagen

Logs

No response

@userquin
Copy link
Collaborator Author

userquin commented Jul 8, 2023

Here the pnpm patch I'm using: vuetifyjs/nuxt-module@6b5e81c

The branch linked in the reproduction has been merged, check it using this another branch (you will need to remove the patch from root package.json file): https://github.com/userquin/vuetify-nuxt-module/blob/userquin/feat-add-icons-support/patches/%40nuxtjs__i18n%408.0.0-beta.13.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants