Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use custom preview page (preview.vue) if exists #101

Merged
merged 2 commits into from
Sep 10, 2020

Conversation

tosbatti
Copy link
Contributor

@tosbatti tosbatti commented Sep 9, 2020

Fix issue #100

@tosbatti
Copy link
Contributor Author

tosbatti commented Sep 9, 2020

Hi @lihbr, I tried to do the fix but I broke the tests 😅
I moved app definition, because it was needed also before.
Sorry, I suppose the problem is quite simple, but I can't figure out which is.

@lihbr
Copy link
Collaborator

lihbr commented Sep 9, 2020

Thank you so much @tosbatti! I'll check that out soon and try to publish a patch before the end of the week ☺️

I'll check for the test also 😉

@lihbr lihbr self-requested a review September 9, 2020 12:01
@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #101   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           48        50    +2     
=========================================
+ Hits            48        50    +2     
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cafa17...4e0d3cc. Read the comment docs.

@tosbatti
Copy link
Contributor Author

tosbatti commented Sep 9, 2020

@lihbr, I found the problem!!! An additional mock was needed for fs.existsSync, as I added a new call.

Copy link
Collaborator

@lihbr lihbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm now 👌

@lihbr lihbr merged commit 39d9dd5 into nuxt-modules:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants