Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(browser): add support of formatted strings #66

Merged
merged 3 commits into from
Sep 1, 2019

Conversation

D34THWINGS
Copy link
Contributor

Hi,

Currently Consola does not support the usage of formatted strings with the BrowserReporter. Example, if you log with the following arguments:

logger.error('Error: %s is not a valid configuration key', 'test')

It will output:

Error: %s is not a valid configuration key test

Instead of:

Error: test is not a valid configuration key

So in this PR, i made a small modification to add the support for this functionality.

Thanks

src/reporters/browser.js Show resolved Hide resolved
src/reporters/browser.js Outdated Show resolved Hide resolved
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@pi0 pi0 changed the title Feat: Add support of formatted strings in browser reporter feat(browser): add support of formatted strings Sep 1, 2019
@pi0 pi0 merged commit 920f313 into unjs:master Sep 1, 2019
@D34THWINGS D34THWINGS deleted the feat-broswer-console-format branch September 1, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants