Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: new LogLevel enum is not exported properly #95

Closed
regevbr opened this issue May 7, 2020 · 0 comments · Fixed by #96
Closed

bug: new LogLevel enum is not exported properly #95

regevbr opened this issue May 7, 2020 · 0 comments · Fixed by #96

Comments

@regevbr
Copy link
Contributor

regevbr commented May 7, 2020

In #94 I added/fixed the typings of the package.
As part of the process I added the LogLevel enum, which I exported in index.js.
When I tried to use the library, I realized that the npm package actually exports the the dist file, which is a minified version of node.js which doesn't export the new enum.
Also, it seems redundant to publish the src files if you expose a minified version.
@pi0 @atinux I will prepare a quick fix not. Can you please give your opinion on the packaging of the src dir in the published package?
@regevbr regevbr mentioned this issue May 7, 2020
Merged
@regevbr regevbr changed the title new LogLevel enum is not exported properly bug: new LogLevel enum is not exported properly May 7, 2020
@pi0 pi0 closed this as completed in #96 May 7, 2020
pi0 pushed a commit that referenced this issue May 7, 2020
@regevbr
fix: new LogLevel enum is not exported properly #95 (#96)
fafbec2
nevilm-lt pushed a commit to nevilm-lt/consola that referenced this issue Apr 22, 2022
@regevbr @nevilm-lt
fix: new LogLevel enum is not exported properly unjs#95 (unjs#96)
cbb8143
himanshiLt pushed a commit to himanshiLt/consola that referenced this issue Jun 20, 2022
@regevbr @himanshiLt
fix: new LogLevel enum is not exported properly unjs#95 (unjs#96)
20073f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: new LogLevel enum is not exported properly #95
1 participant
@regevbr