Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: silent log level does not work #97 #98

Merged
merged 5 commits into from
May 26, 2020
Merged

fix: silent log level does not work #97 #98

merged 5 commits into from
May 26, 2020

Conversation

regevbr
Copy link
Contributor

@regevbr regevbr commented May 7, 2020

fix: #97

@regevbr
Copy link
Contributor Author

regevbr commented May 7, 2020

haha @pi0 sorry to bother you so much, but can you look into it please?

@regevbr
Copy link
Contributor Author

regevbr commented May 9, 2020

I also added a verbose log level which complements the silent log level.
In addition I also fixed some more typings issues I discovered along the way

@regevbr
Copy link
Contributor Author

regevbr commented May 25, 2020

@pi0 can you please CR this?

pi0
pi0 approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💚

@pi0 pi0 merged commit 6a4a79c into unjs:master May 26, 2020
@regevbr regevbr deleted the #97 branch May 26, 2020 18:58
@regevbr
Copy link
Contributor Author

regevbr commented May 26, 2020

Thanks @pi0

@pi0
Copy link
Member

pi0 commented May 26, 2020 •
edited
Loading

No problems and sorry for delay. If you are interested helping for package maintenance, I can send an invitation :)

@regevbr
Copy link
Contributor Author

regevbr commented May 26, 2020

Thanks for proposal! Sure that will be great 😊 my time is limited now but I would love to help where I can

nevilm-lt pushed a commit to nevilm-lt/consola that referenced this pull request Apr 22, 2022
@regevbr @nevilm-lt
fix: silent log level does not work (unjs#98)
dbf4873
himanshiLt pushed a commit to himanshiLt/consola that referenced this pull request Jun 20, 2022
@regevbr @himanshiLt
fix: silent log level does not work (unjs#98)
15066d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

silent log level does not work
2 participants
@regevbr @pi0