fix(nuxt): don't inline styles for per-request ssr: false (#8106)

Co-authored-by: Alex C <alex.canals@jkweb.ch>
nuxt · Oct 12, 2022 · 6ef6eae · 6ef6eae
1 parent bda187c
commit 6ef6eae
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/packages/nuxt/src/core/runtime/nitro/renderer.ts b/packages/nuxt/src/core/runtime/nitro/renderer.ts
@@ -205,7 +205,7 @@ export default defineRenderHandler(async (event) => {
   const renderedMeta = await ssrContext.renderMeta?.() ?? {}
 
   // Render inline styles
-  const inlinedStyles = process.env.NUXT_INLINE_STYLES
+  const inlinedStyles = process.env.NUXT_INLINE_STYLES && !(process.env.NUXT_NO_SSR || ssrContext.noSSR)
     ? await renderInlineStyles(ssrContext.modules ?? ssrContext._registeredComponents ?? [])
     : ''
 

diff --git a/test/basic.test.ts b/test/basic.test.ts
@@ -598,7 +598,7 @@ describe.skipIf(process.env.NUXT_TEST_DEV || process.env.TEST_WITH_WEBPACK)('inl
       '{--assets:"assets"}', // <script>
       '{--scoped:"scoped"}', // <style lang=css>
       '{--postcss:"postcss"}', // <style lang=postcss>
-      '{--global:"global"}', // entryfile dependency
+      '{--global:"global"', // entryfile dependency
       '{--plugin:"plugin"}', // plugin dependency
       '{--functional:"functional"}' // functional component with css import
     ]) {

diff --git a/test/fixtures/basic/assets/global.css b/test/fixtures/basic/assets/global.css
@@ -1,3 +1,4 @@
 :root {
   --global: 'global';
+  --asset: url('~/assets/logo.svg');
 }